Add Inputs/Outputs check interface #4438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Sep 27, 2017
paddle/framework/shape_inference.h
Outdated
| const std::vector<std::string> &names = Inputs(name); | ||
| return names.size() > 0; | ||
| } | ||
| bool HasOutputs(const std::string &name) const { |
There was a problem hiding this comment.
Check var in scope, so we need a virtual function.
jacquesqiao
reviewed
Sep 28, 2017
paddle/framework/shape_inference.h
Outdated
| virtual bool HasInput(const std::string &name) const = 0; | ||
| virtual bool HasOutput(const std::string &name) const = 0; | ||
| bool HasInputs(const std::string &name) const { | ||
| const std::vector<std::string> &names = Inputs(name); |
There was a problem hiding this comment.
I think we need to check if these variables are all in the scope~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4434