Skip to content

Conversation

@From00
Copy link
Contributor

@From00 From00 commented Jun 29, 2022

PR types

Others

PR changes

Others

Describe

为绕开PR #43100 中遇到的将FetchResultType由boost::variant替换成paddle::variant后触发Windows平台installation_validate错误问题,将ParalleExecutor的run接口改造成不返回FetchResultType。
改造前:

using FetchResultType = boost::variant<FetchList, FetchUnmergedList>;
FetchResultType Run(const std::vector<std::string> &fetch_tensors,
                      bool return_merged = true);

改造后:

FetchUnmergedList Run(const std::vector<std::string> &fetch_tensors);
FetchList RunAndMerge(const std::vector<std::string> &fetch_tensors);

同时将FetchResultType由boost::variant替换成paddle::variant。

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit f720e23 into PaddlePaddle:develop Jun 30, 2022
@From00 From00 mentioned this pull request Jul 11, 2022
@From00 From00 deleted the remove-boost-variant-for-fetch-result-type branch April 5, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants