Skip to content

rename LoDTensor::Slice to Shrink #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2017
Merged

rename LoDTensor::Slice to Shrink #4343

merged 1 commit into from
Sep 23, 2017

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Sep 22, 2017 •
edited
Loading

resolves: #4344

jacquesqiao
jacquesqiao reviewed Sep 23, 2017
View reviewed changes
paddle/framework/lod_tensor_test.cc
@@ -56,19 +56,19 @@ TEST_F(LoDTensorTester, NumElements) {
ASSERT_EQ(lod_tensor_.NumElements(2), 8UL);
}

TEST_F(LoDTensorTester, SliceLevels) {
TEST_F(LoDTensorTester, ShrinkLevels) {
// slice 1 level
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slice => shrink

jacquesqiao
jacquesqiao reviewed Sep 23, 2017
View reviewed changes
paddle/framework/lod_tensor_test.cc
// slice 1 level
for (size_t level = 0; level < 3UL; ++level) {
LoDTensor new_lod_tensor = lod_tensor_;
new_lod_tensor.SliceLevels(level, level + 1);
new_lod_tensor.ShrinkLevels(level, level + 1);
ASSERT_EQ(new_lod_tensor.NumLevels(), 1UL);
ASSERT_EQ(new_lod_tensor.NumElements(0), lod_tensor_.NumElements(level));
ASSERT_EQ(new_lod_tensor.data<float>(), lod_tensor_.data<float>());
}
// slice 2 level
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slice => shrink

jacquesqiao
jacquesqiao approved these changes Sep 23, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but should change the two comment before merge

@Superjomn Superjomn merged commit fdc4d4a into PaddlePaddle:develop Sep 23, 2017
@Superjomn Superjomn deleted the feature/lod_slice_return_slice branch September 23, 2017 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoDTensor::Slice() is void function without a new object returned
2 participants
@Superjomn @jacquesqiao