Skip to content

[new-exec] enable the new standalone executor by default #41179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 5, 2022
Merged

[new-exec] enable the new standalone executor by default #41179

merged 14 commits into from
Apr 5, 2022

Conversation

zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Mar 30, 2022 •
edited
Loading

PR types

New features

PR changes

Others

Describe

  • enable standalone executor by default

set FLAGS_USE_STANDALONE_EXECUTOR=false to use the legacy executor

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 30, 2022 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhiqiu zhiqiu force-pushed the dev/enable_new_exe2 branch from 7f3f46d to f367cd8 Compare March 31, 2022 07:28
@zhiqiu zhiqiu force-pushed the dev/enable_new_exe2 branch 2 times, most recently from 1754187 to 1004f18 Compare April 2, 2022 03:17
@zhiqiu zhiqiu force-pushed the dev/enable_new_exe2 branch from 1004f18 to 4644a30 Compare April 2, 2022 09:35
@zhiqiu zhiqiu force-pushed the dev/enable_new_exe2 branch from 6394d4f to 2f9ec80 Compare April 3, 2022 11:10
@zhiqiu zhiqiu force-pushed the dev/enable_new_exe2 branch from 9d8153b to f40beb1 Compare April 4, 2022 15:05
@zhiqiu zhiqiu changed the title enable new exe2 [new-exec] enable the new standalone executor by default Apr 4, 2022
Shixiaowei02
Shixiaowei02 previously approved these changes Apr 4, 2022
View reviewed changes
@zhiqiu zhiqiu force-pushed the dev/enable_new_exe2 branch from f40beb1 to 13df135 Compare April 4, 2022 15:16
XieYunshen
XieYunshen approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

From00
From00 approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@From00 From00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Several UTs (test_nn_grad, test_norm_nn_grad, and test_trt_multiclass_nums3_op) randomly got TIMEOUT in standalone executor, we will fix them out later.

@phlrain phlrain self-requested a review April 4, 2022 16:26
@zhiqiu zhiqiu merged commit 93ea129 into PaddlePaddle:develop Apr 5, 2022
@From00 From00 mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@From00 From00 From00 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@phlrain phlrain phlrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhiqiu @From00 @XieYunshen @Shixiaowei02 @phlrain