heter & multi-cloud brpc communication #40965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
fuyinno4
reviewed
Mar 30, 2022
| DEFINE_int32(pserver_sparse_table_shard_num, 1000, | ||
| "sparse table shard for save & load"); | ||
|
|
||
| DEFINE_int32(heter_world_size, 100, "group size"); // 可配置 |
| heter_service_proto fleet_executor ${BRPC_DEP}) | ||
| set(DISTRIBUTE_COMPILE_FLAGS "-Wno-non-virtual-dtor -Wno-error=non-virtual-dtor -Wno-error=delete-non-virtual-dtor") | ||
| set(DISTRIBUTE_COMPILE_FLAGS "-Wno-non-virtual-dtor -Wno-error=non-virtual-dtor -Wno-error=delete-non-virtual-dtor -Wno-error=parentheses") | ||
| if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7.0) |
There was a problem hiding this comment.
能编过，消除所依赖的第三方库的代码带来的编译告警
| // std::vector<std::shared_ptr<brpc::Controller>> _cntls; | ||
| }; | ||
|
|
||
| class HeterClient { |
There was a problem hiding this comment.
这个类一开始就是个独立的类，它没所谓的table，还有很多定制化的接口，var存储在scope里的。
There was a problem hiding this comment.
这个client其实不是ps通信的，worker之间的
fuyinno4
approved these changes
Mar 30, 2022
chenwhql
approved these changes
Mar 30, 2022
zhwesky2010
approved these changes
Mar 30, 2022
raindrops2sea
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
add new features in HeterClient and HeterServer