Skip to content

[Phi] Migrate Adam and AdamW into Phi #40351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 25, 2022
Merged

[Phi] Migrate Adam and AdamW into Phi #40351

merged 23 commits into from
Mar 25, 2022

Conversation

Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Mar 9, 2022 •
edited
Loading

PR types

Function optimization

PR changes

OPs

Describe

[Phi] Migrate Adam and AdamW into Phi

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 9, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

DannyIsFunny
DannyIsFunny reviewed Mar 11, 2022
View reviewed changes
@Aurelius84 Aurelius84 mentioned this pull request Mar 11, 2022
Merged
YuanRisheng
YuanRisheng reviewed Mar 11, 2022
View reviewed changes
@Aurelius84 Aurelius84 requested a review from YuanRisheng March 11, 2022 09:37
zyfncg
zyfncg reviewed Mar 11, 2022
View reviewed changes
zyfncg
zyfncg previously approved these changes Mar 15, 2022
View reviewed changes
YuanRisheng
YuanRisheng previously approved these changes Mar 15, 2022
View reviewed changes
MingMingShangTian
MingMingShangTian previously approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain self-requested a review March 25, 2022 02:54
XiaoguangHu01
XiaoguangHu01 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 56cd340 into PaddlePaddle:develop Mar 25, 2022
Aurelius84 added a commit to Aurelius84/Paddle that referenced this pull request Apr 12, 2022
@Aurelius84
Revert "[Phi] Migrate Adam and AdamW into Phi (PaddlePaddle#40351)"
5ba790a 
This reverts commit 56cd340.
phlrain pushed a commit that referenced this pull request Apr 13, 2022
@Aurelius84
Revert "[Phi] Migrate Adam and AdamW into Phi (#40351)" (#41712)
8663376 
* Revert "[Phi] Migrate Adam and AdamW into Phi (#40351)"

This reverts commit 56cd340.

* add infermeta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zyfncg zyfncg zyfncg approved these changes

@chenwhql chenwhql chenwhql approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@phlrain phlrain phlrain approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@DannyIsFunny DannyIsFunny Awaiting requested review from DannyIsFunny

@MingMingShangTian MingMingShangTian Awaiting requested review from MingMingShangTian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Aurelius84 @zyfncg @MingMingShangTian @chenwhql @YuanRisheng @phlrain @DannyIsFunny @XiaoguangHu01