[Phi] Remove needless deps in unittests #40256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… phi/remove_needless_deps_in_unittests
… phi/remove_needless_deps_in_unittests
… phi/remove_needless_deps_in_unittests
chenwhql
requested review from
JiabinYang,
XiaoguangHu01,
jim19930609 and
zyfncg
YuanRisheng
approved these changes
Mar 11, 2022
jim19930609
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Describe
[Phi] Remove needless deps in unittests
#include "paddle/phi/kernels/declarations.h"这里
declarations.h头文件包含所有phi kernel的实现文件中的符号导出所需要的符号声明，include这个头文件会导致编译对象带有全部phi kernel的实现由于
phi/api/lib/api.ccinclude了declarations.h，间接导致phi/tests/api目录下的单测、fluid/eager/tests目录下新动态图的单测、以及使用了具体op的其他单测，在编译时都依赖了phi的全部kernel，这导致的随着phi kernel迁移数目的增多，这数十个单测编译体积会逐渐增大，本PR移除这一依赖。在coverage CI编译前后的相关目录体积对比如下：
本PR前build整体目录大小：
本PR后build整体目录大小：
后续需要特别注意
#include "paddle/phi/kernels/declarations.h"的使用！！！