Enabled test_matmul_v2_op for final state Eager Dygraph #39504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiqiu
reviewed
Feb 16, 2022
| """ | ||
| case 1 | ||
| """ | ||
| '\n case 1\n ' |
There was a problem hiding this comment.
Hmmm, it's a change from astunparse, let's sync offline.
| user_defined_grads=[self.grad_x, self.grad_y], | ||
| user_defined_grad_outputs=[self.grad_out]) | ||
| user_defined_grad_outputs=[self.grad_out], | ||
| check_eager=False) |
There was a problem hiding this comment.
why check_eager is false here？
There was a problem hiding this comment.
We haven't supported Type Promotion at Dygraph level yet, so I turned of eager mode test for "test_check_grad_normal" and "test_check_grad_ignore_y" for now.
jim19930609
force-pushed
the
enable_matmul_v2_test
branch
from
787ddde to
71cc291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Enabled test_matmul_v2_op for final state Eager Dygraph