Move norm to pten #39324
Merged
Move norm to pten #39324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Jan 29, 2022
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| #include "paddle/fluid/operators/eigen/eigen_function.h" |
| // limitations under the License. | ||
|
|
||
| #include "paddle/pten/kernels/norm_kernel.h" | ||
| #include "paddle/fluid/operators/eigen/eigen_function.h" |
| namespace cub = hipcub; | ||
| #endif | ||
| #include "paddle/fluid/operators/amp/fp16_type_traits.h" | ||
| #include "paddle/fluid/platform/bfloat16.h" |
| namespace cub = hipcub; | ||
| #endif | ||
| #include "paddle/fluid/operators/amp/fp16_type_traits.h" | ||
| #include "paddle/fluid/platform/bfloat16.h" |
chenwhql
reviewed
Jan 29, 2022
paddle/fluid/operators/norm_op.cc
Outdated
| @@ -72,6 +72,12 @@ class NormOp : public framework::OperatorWithKernel { | |||
| ctx->SetOutputDim("Norm", xdim); | |||
| } | |||
| } | |||
|
|
|||
| framework::KernelSignature GetExpectedPtenKernelArgs( | |||
There was a problem hiding this comment.
前向的这个映射函数建议就在pten/ops/compat目录下维护吧
| #include "paddle/pten/core/ddim.h" | ||
|
|
||
| namespace pten { | ||
| inline void GetDims( |
There was a problem hiding this comment.
impl目录下定位是放置CPU和GPU代码公用的kernel实现，如果只是辅助函数，建议将函数放到pten/funcs，比如可以放到pten/funcs/common_shape.h中
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
There was a problem hiding this comment.
是不是需要include一下norm_grad_kernel.h
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
| @@ -154,4 +154,6 @@ def test_norm_x_type(): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
| import paddle | |||
… move_norm_to_pten
… move_norm_to_pten
… move_norm_to_pten
… move_norm_to_pten
… move_norm_to_pten
… move_norm_to_pten
chenwhql
approved these changes
Feb 8, 2022
zyfncg
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
OPs
Describe
move norm to pten