Skip to content

Conversation

zhaocaibei123
Copy link
Contributor

@zhaocaibei123 zhaocaibei123 commented Jan 26, 2022

PR types

Function optimization

PR changes

Others

Describe

  1. GeoMemorySparseTable replaces SparseGeoTable, which inherits CommonSparseTable
  2. unify hash in comm&brpc client: shard_id = key % server_num
  3. Channel replaces BlockingQueue for sparse_id_queues_ in comm

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jan 26, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhaocaibei123 zhaocaibei123 changed the title Geo 20220126 geo memory sparse table Jan 29, 2022
Copy link
Contributor

@yaoxuefeng6 yaoxuefeng6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaoxuefeng6 yaoxuefeng6 merged commit 9b3b53b into PaddlePaddle:develop Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants