-
Notifications
You must be signed in to change notification settings - Fork 5.7k
[Pten]Move kernel_primitives lib to Pten directory #39169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pten]Move kernel_primitives lib to Pten directory #39169
Conversation
Thanks for your contribution! |
#include "paddle/fluid/platform/enforce.h" | ||
#include "paddle/fluid/platform/float16.h" | ||
#include "paddle/pten/kernels/funcs/eigen/extensions.h" | ||
#include "paddle/pten/kernels/primitive/functor_primitives.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
文件是否可以删除 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后续进行删除
@@ -0,0 +1,255 @@ | |||
// Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是否需要改成2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个pr我改一下,3q
|
||
#pragma once | ||
|
||
#include "paddle/fluid/operators/amp/fp16_type_traits.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此处包含fluid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fp16_type_traits.h目前没有迁移到pten下,先暂时引用fluid头文件,待该文件迁移后进行修改
@@ -0,0 +1,69 @@ | |||
// Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
@@ -22,11 +22,10 @@ | |||
#endif | |||
|
|||
#include "paddle/fluid/platform/device/gpu/gpu_device_function.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fluid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
该头文件内容未迁移到pten下,待后续迁移后修改
}; | ||
|
||
} // namespace kernel_primitives | ||
namespace kernel_primitives = pten::kps; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
希望尽快删除该文件,该文件只在paddle/fluid/operators/kernel_primitives/kernel_primitives.h中使用,可以只修改paddle/fluid/operators/kernel_primitives/kernel_primitives.h中的头文件引用。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ci op benchmark
PR types
Others
PR changes
Others
Describe
将fluid下的kernel_primitives库迁移到Pten下