Modified Reduce for XPU2 #38918
Merged
Modified Reduce for XPU2 #38918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
AnnaTrainingG
force-pushed
the
Reduce_xpu
branch
from
d0eec90 to
66a52ce
Compare
AnnaTrainingG
force-pushed
the
Reduce_xpu
branch
from
66a52ce to
b1d0000
Compare
|
Sorry to inform you that b1d0000's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
AnnaTrainingG
force-pushed
the
Reduce_xpu
branch
from
b1d0000 to
c3fcc89
Compare
AnnaTrainingG
force-pushed
the
Reduce_xpu
branch
from
c3fcc89 to
f044d94
Compare
AnnaTrainingG
force-pushed
the
Reduce_xpu
branch
from
f044d94 to
d8bf181
Compare
AnnaTrainingG
force-pushed
the
Reduce_xpu
branch
from
bac2209 to
572362b
Compare
zkh2016
approved these changes
Mar 3, 2022
xingfeng01
approved these changes
Mar 3, 2022
| const std::vector<int>& cal_dims, | ||
| const std::vector<int>& cal_strides, | ||
| const std::vector<int>& full_strides) | ||
| : dim(dim) { |
There was a problem hiding this comment.
在 PR 注释里或者代码注释里说明一下修改的原因和逻辑吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
Modified Reduce for XPU2
修改点：
1.将Reduce中的XPU的block size修改为： 64 (XPU2最大只支持64）
2.Reduce any在case较大时会出现计算错误的情况，目前已经修复