Add the backward support for QR #38824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
jeff41404
reviewed
Jan 10, 2022
Comment on lines
53
to
55
| # a = np.array([[1, 2, 3, 2], [4, 5, 6, 3], [7, 8, 7, 4]]).astype(dtype) | ||
| # a = np.array([[1, 2], [3, 4], [5, 6]]).astype(dtype) | ||
| # a = np.array([[[1, 2], [3, 4], [5, 6]], [[1, 2], [3, 4], [5, 6]]]).astype(dtype) |
There was a problem hiding this comment.
no need this annotation?
jeff41404
reviewed
Jan 10, 2022
Comment on lines
81
to
87
| # dQ = np.array([[1, 1, 1], [1, 1, 1], [1, 1, 1]]).astype(self.dtype) | ||
| # dR = np.array([[1, 1, 1, 1], [1, 1, 1, 1], [1, 1, 1, 1]]).astype(self.dtype) | ||
| # dQ = np.array([[1, 1], [1, 1], [1, 1]]).astype(self.dtype) | ||
| # dR = np.array([[1, 1], [1, 1]]).astype(self.dtype) | ||
| # dQ = np.array([[[1, 1], [1, 1], [1, 1]], [[1, 1], [1, 1], [1, 1]]]).astype(self.dtype) | ||
| # dR = np.array([[[1, 1], [1, 1]], [[1, 1], [1, 1]]]).astype(self.dtype) | ||
| # self.check_grad(['X'], ['Q', 'R'], user_defined_grad_outputs=[dQ, dR]) |
There was a problem hiding this comment.
no need this annotation?
XieYunshen
previously approved these changes
Jan 10, 2022
XieYunshen
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
The PR adds the backward support for QR decomposition.