Remove useless headers for some grad ops #38732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
JamesLim-sy
force-pushed
the
remove_useless_header_in_elementwise_mul_grad
branch
from
0bffe58 to
f3c5934
Compare
JamesLim-sy
changed the title
JamesLim-sy
changed the title
JamesLim-sy
changed the title
Zjq9409
reviewed
Jan 6, 2022
| @@ -13,6 +13,7 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. */ | |||
|
|
|||
| #include "paddle/fluid/operators/elementwise/elementwise_div_op.h" | |||
| #include "paddle/fluid/operators/reduce_ops/reduce_op.cu.h" | |||
|
|
|||
There was a problem hiding this comment.
#include "paddle/fluid/operators/reduce_ops/reduce_op.cu.h" 可以不需要加吧
| #include "paddle/fluid/operators/reduce_ops/reduce_op.cu.h" | ||
| #include "paddle/fluid/platform/complex.h" |
There was a problem hiding this comment.
#include "paddle/fluid/operators/reduce_ops/reduce_op.cu.h" 可以不需要加
There was a problem hiding this comment.
Cool ! I wiil revert this pr for completely remove of total useless headers, thanks
JamesLim-sy
added a commit
that referenced
this pull request
Jan 6, 2022
This reverts commit c0e2b98.
JamesLim-sy
added a commit
that referenced
this pull request
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe