[Performance fix] Make GetBlob assuming elements are cached #38336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
@pawelpiotrowicz , @tsocha , @Silv3S, @piotrekobiIntel, @zuzg Please review |
pawelpiotrowicz
approved these changes
Dec 22, 2021
| #define likely(expr) (expr) | ||
| #define unlikely(expr) (expr) | ||
| #else | ||
| #define likely(expr) (__builtin_expect(!!(expr), 1)) |
There was a problem hiding this comment.
Why are using double !! ??
There was a problem hiding this comment.
__builtin_expect does accept long integer arguments. Comparison among boolean and int may raise a warning. So it was "double negated" so True is converted to 1, False to 0 and compared with long in of 1 or 0.
|
@Aganlengzi Please review and merge if correct |
ghost
approved these changes
Dec 23, 2021
lidanqing-intel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
GetBlob is very often used function and majority of it is executed under critical section so it is good to optimize it as much as possible. In this PR we add assumption that objects in cache are there e.g. we instruct compiler to generate code layout in favour of situation that objects are cached. Performance improvement is x < 1% on mobilenetv1_int8 CLX