[PTen]Move elementwise kernel to new directory #38221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Dec 16, 2021
| for (int i = 0; i < Arity; i++) { | ||
| ins_data[i] = ins[i]->data<InT>(); | ||
| } | ||
| #ifdef PADDLE_WITH_XPU2 |
There was a problem hiding this comment.
需要确认下，PADDLE_WITH_XPU2表示这个函数也可以在XPU使用吗？如果是这样的话，这里的函数就属于公共函数了
There was a problem hiding this comment.
这个已和相关同学沟通，目前还未扩展到xpu，后边会一起挪到公共函数里
|
|
||
| } // namespace pten | ||
|
|
||
| #define DEFINE_CPU_ELEMENTWISE_OP(name) \ |
There was a problem hiding this comment.
这两个宏建议分别放到对应的cc或cu中了，其他地方不应该使用了，新目录结构下，这样更好一些
There was a problem hiding this comment.
done,thankyou very much
|
|
||
| using DDim = paddle::framework::DDim; | ||
| using CPUContext = paddle::platform::CPUDeviceContext; |
There was a problem hiding this comment.
include头文件，而不是using context
There was a problem hiding this comment.
done,thankyou very much
| @@ -131,6 +131,7 @@ class MidWiseTransformIterator<T, CPUContext> | |||
| }; | |||
|
|
|||
| #if defined(__NVCC__) || defined(__HIPCC__) | |||
| using CUDAContext = paddle::platform::CUDADeviceContext; | |||
zyfncg
reviewed
Dec 16, 2021
|
|
||
| using DDim = paddle::framework::DDim; | ||
| using CPUContext = paddle::platform::CPUDeviceContext; |
There was a problem hiding this comment.
这里的CPUContext是不是需要include pten最新的Context头文件？
There was a problem hiding this comment.
done,thankyou very much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
将elementwise kernel（elementwise_add/sub/mul/div）按照新设计的目录标准进行拆分放置。Pten新目录kernel放置原则参照：#37916