block xxhash warning of c4711 #37442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betterpig
force-pushed
the
block_xxhash
branch
from
2db3c1b to
7fb92a5
Compare
zhwesky2010
reviewed
Nov 24, 2021
cmake/external/xxhash.cmake
Outdated
| @@ -31,6 +31,9 @@ ENDIF() | |||
|
|
|||
| if (WIN32) | |||
| set(XXHASH_LIBRARIES "${XXHASH_INSTALL_DIR}/lib/xxhash.lib") | |||
| # block warning about inline function | |||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /wd4710 /wd4711") | |||
There was a problem hiding this comment.
这个会影响其他target，直接写到下面吧 -DCMAKE_CXX_FLAGS="${CMAKE_CXX_FLAGS} /wd4710 /wd4711"
zhwesky2010
approved these changes
Nov 26, 2021
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* block xxhash warning of c4711 * modify according to zhouwei's comment * fix syntax error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
block xxhash's warning C4711: function * selected for automatic inline expansion when build in windows
before
after