Skip to content

Setitem support passing stop_gradient from value to tensor #37023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Setitem support passing stop_gradient from value to tensor #37023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions paddle/fluid/pybind/imperative.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,12 @@ void BindImperative(py::module *m_ptr) {
auto value_tensor =
value_obj.cast<std::shared_ptr<imperative::VarBase>>();
ins.insert({"ValueTensor", {value_tensor}});

// pass the stop_gradient from value to tensor
if (!value_tensor->OverridedStopGradient() &&
self->OverridedStopGradient()) {
self->SetOverridedStopGradient(false);
}
} else if (py::isinstance<py::array>(value_obj)) {
auto value_tensor = std::shared_ptr<imperative::VarBase>(
new imperative::VarBase(false,
Expand Down
12 changes: 12 additions & 0 deletions python/paddle/fluid/tests/unittests/test_set_value_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,6 +1154,18 @@ def set_value5(t, value):
msg="The gradient of input should be \n{},\n but reveived {}".
format(value_grad, value.grad.numpy()))

# case 6: pass stop_gradient from value to x
x = paddle.zeros([8, 8], dtype='float32')
value = paddle.to_tensor([10], dtype='float32', stop_gradient=False)

self.assertTrue(x.stop_gradient)
self.assertTrue(x.is_leaf)

x[0, :] = value

self.assertTrue(~x.stop_gradient)
self.assertTrue(~x.is_leaf)

def test_static_graph(self):
paddle.enable_static()

Expand Down