Skip to content

Add LRUCache for fft plans #36646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 27, 2021
Merged

Add LRUCache for fft plans #36646

merged 9 commits into from
Oct 27, 2021

Conversation

iclementine
Copy link

PR types

Performance optimization

PR changes

Ops

Describe

Add LRUCache for fft plans on cuda and rocm backends.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Xreki
Xreki previously approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark ci

chenwhql
chenwhql previously approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

@iclementine iclementine dismissed stale reviews from chenwhql and Xreki via f86c216 October 26, 2021 03:24
@iclementine iclementine mentioned this pull request Oct 26, 2021
Merged
jeff41404
jeff41404 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Xreki
Xreki approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark ci

@jeff41404 jeff41404 merged commit 737992e into PaddlePaddle:develop Oct 27, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
@cxxly @piotrekobi
Add LRUCache for fft plans (PaddlePaddle#36646)
87d730c 
* WIP: add cache

* delete move constructor and operator= for CuFFTHandle and FFTConfig

* remove log from CuFFTHandle and FFTConfig

* add lrucache for fft rocm backend

* disable LRUCache when CUFFT_VERSION >= 10200

* disbale copy and move for hipFFTHandle; format code

* clean debug code

Co-authored-by: Xiaoxu Chen <chenxx_id@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

@Xreki Xreki Xreki approved these changes

@chenwhql chenwhql chenwhql approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iclementine @jeff41404 @Xreki @chenwhql @cxxly