Skip to content

fix wrong trt dim when input dim is 2 #36614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2021
Merged

fix wrong trt dim when input dim is 2 #36614

merged 3 commits into from
Oct 26, 2021

Conversation

baoachun
Copy link
Contributor

@baoachun baoachun commented Oct 21, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

1、修复当输入的nbDims为2时，trt获取到4维的nbDims问题。
2、删除不必要的intance_norm converter单测。
3、更新leaky_relu converter单测。
4、更新instance_norm converter单测。
5、将instance_norm plugin的enqueue中的维度check移到op_teller中。

shangzhizhou
shangzhizhou reviewed Oct 22, 2021
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要加个单测

shangzhizhou
shangzhizhou reviewed Oct 23, 2021
View reviewed changes
paddle/fluid/inference/tests/api/CMakeLists.txt
@@ -555,10 +555,6 @@ if(WITH_GPU AND TENSORRT_FOUND)
if (NOT EXISTS ${TEST_SPLIT_CONVERTER_MODEL}/split_converter.tgz)
inference_download_and_uncompress_without_verify(${TEST_SPLIT_CONVERTER_MODEL} ${INFERENCE_URL}/tensorrt_test "split_converter.tgz")
endif()
set(TEST_INSTANCE_NORM_MODEL "${TRT_MODEL_INSTALL_DIR}/trt_instance_norm_test")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删掉单测是否有替代单测？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有的，test_trt_convert_instance_norm.py这个

shangzhizhou
shangzhizhou approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit 43dcf23 into PaddlePaddle:develop Oct 26, 2021
@baoachun baoachun mentioned this pull request Oct 26, 2021
Merged
@baoachun baoachun deleted the fix_dim branch October 26, 2021 05:44
Superjomn pushed a commit that referenced this pull request Oct 26, 2021
@baoachun
fix wrong trt dim when input dim is 2 (#36614) (#36732)
da6e514 
* fix wrong trt dim when input dim is 2

* update leaky_relu and instance_norm converter unit test

* add instance_norm input dim check
@baoachun baoachun mentioned this pull request Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhizhou shangzhizhou shangzhizhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baoachun @shangzhizhou