Skip to content

reduce some compile warning #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacquesqiao merged 1 commit into from
Aug 24, 2017
Merged

reduce some compile warning #3645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions paddle/gserver/gradientmachines/RecurrentGradientMachine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,8 +1399,8 @@ void RecurrentGradientMachine::createDataOutlinkCopySizeInfo(
getBeamSize() > 1 ? finalPaths_.size() : finalPaths_[0].size());
int* starts = inputSeqStartPos->getMutableData(false);
int seqId = 0;
for (int i = 0; i < finalPaths_.size(); ++i) {
for (int j = 0; j < finalPaths_[i].size(); ++j) {
for (size_t i = 0; i < finalPaths_.size(); ++i) {
for (size_t j = 0; j < finalPaths_[i].size(); ++j) {
Copy link
Collaborator

@JiayiFeng JiayiFeng Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use size_t in for loop: https://google.github.io/styleguide/cppguide.html#Integer_Types

You can write like this:

for (int i = 0; i < int(finalPaths_.size()); ++i) {
  for (int j = 0; j < int(finalPaths_[i].size()); ++j) {
    // ...
  }
}

Copy link
Member Author

@jacquesqiao jacquesqiao Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not quit understand why it's not good to use size_t in a for loop. Instead it writes:
When appropriate, you are welcome to use standard types like size_t and ptrdiff_t.

and here has some other explanation.
https://stackoverflow.com/questions/1951519/when-should-i-use-stdsize-t

Copy link
Collaborator

@JiayiFeng JiayiFeng Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can follow this principle:
If you want to traverse a vector or an array with for loop, size_t is acceptable, otherwise use int instead.

Copy link
Member Author

@jacquesqiao jacquesqiao Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Collaborator

@reyoung reyoung Aug 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Canpio I think we should not obey google c++ style for this situation.

Because all STL containers are rewritten in google. They make containers' size_type as int. We are using std's containers like unordered_map, vector, which size_type is size_t.

So maybe just use size_t is fine. Using int only has an advantage when reversely access a container,i.e., when uses -- operator.

copySize[seqId] = getBeamSize() > 1 ? starts[i + 1] - starts[i]
: starts[j + 1] - starts[j];
batchMachineStartPos_[seqId + 1] =
Expand Down
2 changes: 1 addition & 1 deletion paddle/operators/net_op_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ TEST(NetOp, Clone) {
ASSERT_NE(new_net_op, nullptr);
ASSERT_TRUE(new_net_op->IsNetOp());
auto* new_net = static_cast<NetOp*>(new_net_op.get());
ASSERT_EQ(2, new_net->ops_.size());
ASSERT_EQ(2UL, new_net->ops_.size());
ASSERT_EQ(new_net->ops_[0]->Type(), "empty");
ASSERT_EQ(new_net->ops_[1]->Type(), "empty2");
}
Expand Down