Adapting to the BatchNorm structure to support 3D data #3594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
force-pushed
the
Adapting_to_the_BatchNorm_structure_to_support_3D_data
branch
2 times, most recently
from
3cd0ec1 to
16bd861
Compare
chengduoZH
force-pushed
the
Adapting_to_the_BatchNorm_structure_to_support_3D_data
branch
2 times, most recently
from
959ed40 to
965bd40
Compare
qingqing01
reviewed
Aug 31, 2017
| @@ -16,4 +16,4 @@ | |||
|
|
|||
| if __name__ == '__main__': | |||
| parse_config_and_serialize( | |||
| 'trainer_config_helpers/tests/layers_test_config.py', '') | |||
| 'trainer_config_helpers/tests/configs/test_BatchNorm3D.py', '') | |||
There was a problem hiding this comment.
Do not change this line. Add test_BatchNorm3D.py in the file python/paddle/trainer_config_helpers/tests/configs/file_list.sh.
And please merge 3DConv/3DPooling first, then update this PR.
chengduoZH
force-pushed
the
Adapting_to_the_BatchNorm_structure_to_support_3D_data
branch
2 times, most recently
from
d1247d6 to
2c8b5d8
Compare
chengduoZH
force-pushed
the
Adapting_to_the_BatchNorm_structure_to_support_3D_data
branch
from
2c8b5d8 to
30c0df6
Compare
… Adapting_to_the_BatchNorm_structure_to_support_3D_data
qingqing01
reviewed
Sep 4, 2017
proto/ModelConfig.proto
Outdated
| @@ -515,7 +516,8 @@ message LayerConfig { | |||
| // for HuberRegressionLoss | |||
| optional double delta = 57 [ default = 1.0 ]; | |||
|
|
|||
| optional uint64 depth = 58 [ default = 1 ]; | |||
| // for 3D data | |||
| optional double depth = 58 [ default = 1 ]; | |||
There was a problem hiding this comment.
Sorry, It has been fixed
chengduoZH
force-pushed
the
Adapting_to_the_BatchNorm_structure_to_support_3D_data
branch
from
9a93348 to
fe06096
Compare
chengduoZH
force-pushed
the
Adapting_to_the_BatchNorm_structure_to_support_3D_data
branch
from
fe06096 to
eaf23cb
Compare
…l_layers.protostr and new test_sub_nested_seq_select_layer.protostr
qingqing01
approved these changes
Sep 9, 2017
| self.set_layer_size(input_layer.size) | ||
|
|
||
| if len(self.inputs) > 1: | ||
| assert len(self.inputs) == 2 |
There was a problem hiding this comment.
AddToLayer can support more than 2 inputs.
| assert self.get_input_layer(0).width == self.get_input_layer( | ||
| input_index).width | ||
| assert self.get_input_layer(0).depth == self.get_input_layer( | ||
| input_index).depth |
There was a problem hiding this comment.
严格来说，对于Addto，我觉得只需要检测input_layer.size相等即可。
| input_layer = self.get_input_layer(input_index) | ||
| input = self.inputs[input_index] | ||
| if self.config.size == 0: | ||
| size += input_layer.size | ||
|
|
||
| self.set_layer_height_width(self.get_input_layer(0).height, \ | ||
| self.get_input_layer(0).width) | ||
| self.set_layer_depth(self.get_input_layer(0).depth) |
There was a problem hiding this comment.
实际上不只Python这边需要对AddtoLayer ConcatLayer设置height width depth。C++的实现也需要set一下，这样才能支持变长输入。
heavengate
pushed a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
* fix_install_docs * fix_install_docs2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3597
Adapting to the BatchNorm structure to support 3D data