merge CMakeList.txt manual #35378
Merged
merge CMakeList.txt manual #35378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
XieYunshen
previously approved these changes
Sep 2, 2021
Contributor
XieYunshen
left a comment
XieYunshen
left a comment
There was a problem hiding this comment.
LGTM
由于机器原因，jetson上的单测执行时间较长
XieYunshen
previously approved these changes
Sep 3, 2021
shangzhizhou
reviewed
Sep 6, 2021
| #ifdef __HIPCC__ | ||
| // HIP will throw core dump when threads > 256 | ||
| constexpr int num_threads = 256; | ||
| #elif WITH_NV_JETSON |
Member
There was a problem hiding this comment.
这个有测试过么？ __HIPCC__应该是为支持华为硬件的宏，NVIDA的gpu不会运行到这个分支（WITH_GPU的时候不会编译HIP代码）。
Contributor
Author
There was a problem hiding this comment.
这个有测试过么？ __HIPCC__应该是为支持华为硬件的宏，NVIDA的gpu不会运行到这个分支（WITH_GPU的时候不会编译HIP代码）。
经确认逻辑正确
| dim3 threads(1024, 1); | ||
| int thread_num = 1024; | ||
| #ifdef WITH_NV_JETSON | ||
| // platform::ChangeThreadNum(context, &thread_num); |
Contributor
Author
There was a problem hiding this comment.
此处为何没有保持风格一致，也使用函数调用？
这个op比较特殊，在调用的时候不需要传入设备上下文，所以无法根据运行时的实际设备调整线程数，只能在编译的时候指定，如果修改op的参数定义的话，涉及到的调用位置都要补充获取设备上下文参数的逻辑，影响面比较大。这样简单的修改话会影响agx和nx, 不过我让王也测试过，之前的模型性能没有下降，反而略微提升，所以目前看来可以这样指定。
XieYunshen
approved these changes
Sep 7, 2021
2742195759
pushed a commit
to 2742195759/Paddle
that referenced
this pull request
Sep 10, 2021
* merge CMakeList.txt manual * add platform for changethreadnum * repair some bugs according to make error * do nothing just flush CI * forget change thread num * add inplace_atol param for check_output_with_place * Windows * std:min and std::max should be change because of windows
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* merge CMakeList.txt manual * add platform for changethreadnum * repair some bugs according to make error * do nothing just flush CI * forget change thread num * add inplace_atol param for check_output_with_place * Windows * std:min and std::max should be change because of windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
jetson-op-test