Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Add copy from tensor (#34406)" (#35173)" #35256

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Revert "Revert "Add copy from tensor (#34406)" (#35173)" #35256

merged 2 commits into from
Aug 31, 2021

Conversation

shangzhizhou
Copy link
Member

@shangzhizhou shangzhizhou commented Aug 30, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

重新提PR #34406(增加copy_tensor api和异步拷贝接口CopyToCpuAsync)

  1. 因为#34406和CI的优化加速策略冲突，导致ci失败，ci问题已经修复（，C++的单测代码的cmake之前没有关注CI_SKIP_CPP_TEST这个环境变量。目前在cmake的cc_test_build函数里加了CI_SKIP_CPP_TEST的判断，但是set_test_property这个函数一般没有判断，这个时候合入的set_test_property就会报单测不存在的错误），重提PR。
  2. #34406在昇腾环境下执行报错CopyToCpuImpl未定义。经过排查跟模板实例化有关，CopyToCpu和CopyToCpuImpl都是模板函数，代码中只加了CopyToCpu的显示实例化，没有CopyToCpuImpl的显示实例化，在昇腾下未定义错误，增加CopyToCpuImpl的显示实例化后解决。

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 30, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for set_tests_properties(paddle_infer_api_copy_tensor_tester PROPERTIES TIMEOUT 30)

@shangzhizhou shangzhizhou merged commit 6116f9a into PaddlePaddle:develop Aug 31, 2021
@shangzhizhou shangzhizhou deleted the pr_34406 branch September 10, 2021 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shangzhizhou @XieYunshen @Shixiaowei02