Skip to content

Conversation

@heavengate
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Describe

fix drop_last not work on IterableDataset

  • drop_last is processing in IterableDatasetFetcher, which is different from MapDataset, pass drop_last to IterableDatasetFetcher to enable it

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@heavengate heavengate requested a review from chenwhql August 11, 2021 08:36
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavengate heavengate merged commit 1614608 into PaddlePaddle:develop Aug 17, 2021
@heavengate heavengate deleted the fix_iterable_dataset_drop_last_not_work branch August 17, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants