Skip to content

support margin loss (arcface, cosface, sphereface) for single GPU and cross GPUs #34247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sandyhouse merged 15 commits into from
Aug 16, 2021
Merged

support margin loss (arcface, cosface, sphereface) for single GPU and cross GPUs #34247

sandyhouse merged 15 commits into from
Aug 16, 2021

Conversation

@GuoxiaWang
Copy link
Contributor

@GuoxiaWang GuoxiaWang commented Jul 19, 2021

PR types

New features

PR changes

APIs

Describe

margin loss, it is a unified loss, which includes arcface, cosface, sphereface

1

The details of margin loss could be referred to https://arxiv.org/abs/1801.07698.

Note that the APIs support model parallel and single GPU. And Logits.shape[-1] can be different each rank.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 19, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sandyhouse sandyhouse self-requested a review August 9, 2021 12:36
wadefelix
wadefelix suggested changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@wadefelix wadefelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-block指令后应有一个空行

sandyhouse
sandyhouse previously approved these changes Aug 10, 2021
View reviewed changes
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sandyhouse
sandyhouse previously approved these changes Aug 11, 2021
View reviewed changes
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong previously approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sandyhouse
sandyhouse previously approved these changes Aug 12, 2021
View reviewed changes
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 previously approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

sandyhouse
sandyhouse approved these changes Aug 13, 2021
View reviewed changes
Copy link

@sandyhouse sandyhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

@kolinwei kolinwei self-requested a review August 16, 2021 03:48
chenwhql
chenwhql approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PADDLE_ENFORCE

zhiqiu
zhiqiu approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ShareDataWith

XieYunshen
XieYunshen approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyhouse sandyhouse merged commit b0cb414 into PaddlePaddle:develop Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandyhouse sandyhouse sandyhouse approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@kolinwei kolinwei kolinwei approved these changes

@chenwhql chenwhql chenwhql approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

+1 more reviewer

@wadefelix wadefelix wadefelix requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@GuoxiaWang @wadefelix @sandyhouse @zhiqiu @TCChenlong @kolinwei @chenwhql @XieYunshen @raindrops2sea @XiaoguangHu01