add primitives api files #34208
Merged
add primitives api files #34208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Xreki
reviewed
Jul 26, 2021
There was a problem hiding this comment.
是不是不用每个文件都叫xxx_primitives.h？可直接是compute.h这样？
There was a problem hiding this comment.
我觉得加上好一点，op 相关文件的命名都有 _op，另外 "compute.h" 可能会有重名，不是太好
There was a problem hiding this comment.
include头文件，使用相对Paddle的完整路径，比如#include "paddle/fluid/operators/kernel_primitives/compute.h"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
This PR add some primitives api related files. Those files are almost empty for the moment, but will be filled later.