Skip to content

[Dy2Stat] Refactor ExecutorCache logic and pre-support BuildStrategy for pass #34181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aurelius84 merged 6 commits into from
Jul 22, 2021
Merged

[Dy2Stat] Refactor ExecutorCache logic and pre-support BuildStrategy for pass #34181

Aurelius84 merged 6 commits into from
Jul 22, 2021

Conversation

@Aurelius84
Copy link
Contributor

@Aurelius84 Aurelius84 commented Jul 15, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

  1. 重构了 ExecutorCache 的逻辑，将hashKey 放到python端只做1次计算，避免每次执行Op时都频繁地调用HashFunc，减少不必要的开销
  2. 优化了skip_eager_delete_var获取逻辑，将其cacha到ExecutorInfo中，提升解析速度
  3. 新增SetBuildStrategy前端接口，以支持用户在@to_static中指定build_strategy策略
    • 对大Op添加了一个 program_id 属性，便于前后端同步管理cacheInfo，如便捷地支持前端通过program_id设置build_strategy

TODO

  1. Add build_strategy argument in @to_static (NEXT PR)

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 15, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Aurelius84 Aurelius84 changed the title [Dy2Stat]Support BuildStrategy to customize pass [Dy2Stat] Refactor ExecutorCache logic and pre-support BuildStrategy for pass Jul 19, 2021
zhhsplendid
zhhsplendid reviewed Jul 21, 2021
View reviewed changes
@Aurelius84 Aurelius84 requested a review from zhhsplendid July 21, 2021 03:58
zhhsplendid
zhhsplendid approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 requested a review from Superjomn July 22, 2021 08:16
Superjomn
Superjomn approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只动转静使用，推理不会用

chenwhql
chenwhql approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 609f822 into PaddlePaddle:develop Jul 22, 2021
Aurelius84 added a commit to Aurelius84/Paddle that referenced this pull request Jul 23, 2021
@Aurelius84
Revert "[Dy2Stat] Refactor ExecutorCache logic and pre-support BuildS…
4e567f0 
…trategy for pass (PaddlePaddle#34181)"

This reverts commit 609f822.
XieYunshen pushed a commit that referenced this pull request Jul 23, 2021
@Aurelius84
Revert "[Dy2Stat] Refactor ExecutorCache logic and pre-support BuildS…
577fdde 
…trategy for pass (#34181)" (#34348)

This reverts commit 609f822.
Aurelius84 added a commit to Aurelius84/Paddle that referenced this pull request Jul 26, 2021
@Aurelius84
Revert "Revert "[Dy2Stat] Refactor ExecutorCache logic and pre-suppor…
a781332 
…t BuildStrategy for pass (PaddlePaddle#34181)" (PaddlePaddle#34348)"

This reverts commit 577fdde.
@Aurelius84 Aurelius84 mentioned this pull request Jul 26, 2021
Merged
Superjomn pushed a commit that referenced this pull request Jul 27, 2021
@Aurelius84
Revert "Revert "[Dy2Stat] Refactor ExecutorCache logic and pre-suppor…
0dd6a44 
…t BuildStrategy for pass (#34181)" (#34348)" (#34384)

This reverts commit 577fdde.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

@chenwhql chenwhql chenwhql approved these changes

+1 more reviewer

@Superjomn Superjomn Superjomn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aurelius84 @Superjomn @zhhsplendid @chenwhql