Skip to content

fix decoding error when clip grad op and python==2 #33937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2021
Merged

fix decoding error when clip grad op and python==2 #33937

merged 3 commits into from
Jul 5, 2021

Conversation

@jiweibo
Copy link
Contributor

@jiweibo jiweibo commented Jul 2, 2021

PR types

Others

PR changes

Others

Describe

#33919

兼容python2

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jiweibo jiweibo mentioned this pull request Jul 2, 2021
Merged
@jiweibo jiweibo requested a review from OliverLPH July 5, 2021 02:08
OliverLPH
OliverLPH approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@OliverLPH OliverLPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit c661783 into PaddlePaddle:develop Jul 5, 2021
@jiweibo jiweibo deleted the fix_clip_grad branch July 5, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OliverLPH OliverLPH OliverLPH approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiweibo @OliverLPH