Skip to content

Reduce build time by deleting the template param BlockDim #33901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Xreki merged 8 commits into from
Jul 5, 2021
Merged

Reduce build time by deleting the template param BlockDim #33901

Xreki merged 8 commits into from
Jul 5, 2021

Conversation

@ZzSean
Copy link
Contributor

@ZzSean ZzSean commented Jul 1, 2021 •
edited
Loading

PR types

Others

PR changes

OPs

Describe

Reduce build time by deleting the template param BlockDim
15min->3min

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ZzSean ZzSean force-pushed the reduce_build_time branch 2 times, most recently from 808bef6 to 9e1c94f Compare July 1, 2021 08:34
@ZzSean ZzSean force-pushed the reduce_build_time branch from 277a0ea to bc5d183 Compare July 2, 2021 06:02
@ZzSean ZzSean force-pushed the reduce_build_time branch from 70d3ed7 to 1d77eb2 Compare July 2, 2021 06:10
@ZzSean ZzSean marked this pull request as draft July 2, 2021 08:27
@ZzSean ZzSean marked this pull request as ready for review July 2, 2021 08:27
Xreki
Xreki reviewed Jul 5, 2021
View reviewed changes
Xreki
Xreki reviewed Jul 5, 2021
View reviewed changes
@ZzSean ZzSean force-pushed the reduce_build_time branch from e14e2fc to e43ce03 Compare July 5, 2021 07:39
@ZzSean ZzSean force-pushed the reduce_build_time branch from 589b4ab to 46e6e71 Compare July 5, 2021 08:05
Xreki
Xreki approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and great work~

@Xreki Xreki merged commit 7a47660 into PaddlePaddle:develop Jul 5, 2021
@ZzSean ZzSean deleted the reduce_build_time branch July 14, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xreki Xreki Xreki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZzSean @Xreki