Skip to content

Conversation

tianshuo78520a
Copy link
Collaborator

PR types

Others

PR changes

Others

Describe

del python2 code

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wadefelix wadefelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decorator==4.4.2指定版本号的原因就是因为py2么?

Pillow
six
decorator==4.4.2
decorator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job。删了版本号肯定是好事

这个就是为了py2才指定的4.4.2版本么?还是有别的目的指定的版本号?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,当时Py2上需要指定版本号,现在删除能跑过说明可以删除。之前PR:#32043

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wadefelix
Copy link
Contributor

LGTM

@wanghuancoder wanghuancoder merged commit 0b4a7f1 into PaddlePaddle:develop Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants