Add atan2 op and test #33067
Merged
Add atan2 op and test #33067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
qili93
reviewed
May 25, 2021
| @@ -149,6 +149,7 @@ | |||
| from .tensor.math import acos # noqa: F401 | |||
| from .tensor.math import asin # noqa: F401 | |||
| from .tensor.math import atan # noqa: F401 | |||
| from .tensor.math import atan2 # noqa: F401 | |||
There was a problem hiding this comment.
tensor/__init__.py里面也需要添加from .math import atan
|
需要新增docs的中文API文档 |
|
Sorry to inform you that a743bbe's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
TCChenlong
reviewed
Jun 10, 2021
python/paddle/tensor/math.py
Outdated
| .. code-block:: python | ||
|
|
||
| import paddle | ||
| y=paddle.to_tensor([-1, +1, +1, -1]).astype('float32') |
XieYunshen
previously approved these changes
Jun 15, 2021
TCChenlong
previously approved these changes
Jun 15, 2021
lanxianghit
reviewed
Jun 15, 2021
| @@ -839,6 +839,7 @@ set_tests_properties(test_pool2d_op PROPERTIES TIMEOUT 120) | |||
| set_tests_properties(test_transpose_op PROPERTIES TIMEOUT 120) | |||
| set_tests_properties(test_eager_deletion_gru_net PROPERTIES TIMEOUT 120) | |||
| set_tests_properties(test_activation_op PROPERTIES TIMEOUT 270) | |||
| set_tests_properties(test_atan2_op PROPERTIES TIMEOUT 120) | |||
There was a problem hiding this comment.
为什么需要增大单测时间？这个对ci影响比较大，这个op计算量感觉不需要这么长的单测时间，如果目前单测确实需要跑较长时间，是否有优化方法？
There was a problem hiding this comment.
这个op单测本地需要6.x秒，TIMEOUT参照其他op单测设置的，需要改的话我改下
|
|
||
| def atan2(y, x, name=None): | ||
| r""" | ||
| Element-wise arctangent of y/x with consideration of the quadrant. |
python/paddle/tensor/math.py
Outdated
|
|
||
| """ | ||
| check_variable_and_dtype(y, 'y', ['float16', 'float32', 'float64'], 'atan2') | ||
| check_variable_and_dtype(x, 'x', ['float16', 'float32', 'float64'], 'atan2') |
There was a problem hiding this comment.
变量检查应该在动态图调用之后，否则会影响性能
| atan2_grad, ops::Atan2GradKernel<paddle::platform::CPUDeviceContext, float>, | ||
| ops::Atan2GradKernel<paddle::platform::CPUDeviceContext, double>, | ||
| ops::Atan2GradKernel<paddle::platform::CPUDeviceContext, | ||
| paddle::platform::float16>); |
There was a problem hiding this comment.
调查了tensorflow和pytorch，tensorflow不支持int；pytorch前向支持int，且输入int时输出为fp64，反向不支持
更新成和pytorch一致
ronny1996
dismissed stale reviews from TCChenlong, qili93, and XieYunshen
via
fd058e2
TCChenlong
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add atan2 op and test
