Support different data type between input and output #32823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Xreki
approved these changes
May 10, 2021
| } | ||
|
|
||
| template <ElementwiseType ET, typename T, typename Functor> | ||
| template <ElementwiseType ET, typename InT, typename OutT, typename Functor> |
| for (auto iter = ins.begin(); iter != ins.end(); ++iter) { | ||
| vec_size = | ||
| std::min<int>(vec_size, GetVectorizedSizeImpl((*iter)->data<T>())); | ||
| std::min<int>(vec_size, GetVectorizedSizeImpl((*iter)->data<InT>())); |
Contributor
There was a problem hiding this comment.
这个循环的写法其实可以简写成如下：
for (auto in : ins) {
vec_size =
std::min<int>(vec_size, GetVectorizedSizeImpl(in->data<InT>()));
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
OPs
Describe
elementwise 实现模版支持输入和输出的数据类型不同，并适配 abs 验证，性能数据如下：