Skip to content

Move pybind.cc/tensor_bind.h to paddle::framework #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 3, 2017
Merged

Move pybind.cc/tensor_bind.h to paddle::framework #3173

merged 5 commits into from
Aug 3, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Aug 2, 2017

Fix #3171

@reyoung reyoung requested a review from QiJune August 2, 2017 09:11
@reyoung reyoung force-pushed the feature/move_pybind_to_framework_dir branch from f38e6b7 to 3fc68f6 Compare August 2, 2017 11:37
wangkuiyi
wangkuiyi approved these changes Aug 2, 2017
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe rename tensor_bind.{h,cc} into tensor_py.{h,cc}?

@reyoung reyoung merged commit 809793c into PaddlePaddle:develop Aug 3, 2017
@reyoung reyoung deleted the feature/move_pybind_to_framework_dir branch August 5, 2017 09:05
@qingqing01 qingqing01 mentioned this pull request Aug 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@QiJune QiJune Awaiting requested review from QiJune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @wangkuiyi