-
Couldn't load subscription status.
- Fork 5.9k
[CustomOp] Support attributes as func input in custom op #31128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chenwhql
merged 15 commits into
PaddlePaddle:develop
from
chenwhql:extension/custom_op_support_attributes
Feb 25, 2021
Merged
[CustomOp] Support attributes as func input in custom op #31128
chenwhql
merged 15 commits into
PaddlePaddle:develop
from
chenwhql:extension/custom_op_support_attributes
Feb 25, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extension/custom_op_support_attributes
|
Thanks for your contribution! |
… extension/custom_op_support_attributes
… extension/custom_op_support_attributes
… extension/custom_op_support_attributes
… extension/custom_op_support_attributes
… extension/custom_op_support_attributes
Aurelius84
approved these changes
Feb 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XieYunshen
approved these changes
Feb 25, 2021
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Feb 26, 2021
…e#31128) * add simple attr support and test * add int, float attr support * support other attribute * add custom attrs test in cmake * polish details * fix test failed * add backward test * update test flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
[CustomOp] Support attributes as func input in custom op
Supported attr types include:
boolintfloatint64_tstd::stringstd::vector<int>std::vector<float>std::vector<int64_t>std::vector<std::string>The backward func's attributes MUST be the subset of forward func's attributes.