Refine device context and fix GetPlace() #3084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangliao
commented
Jul 27, 2017
| @@ -20,12 +20,96 @@ Eigen::DefaultDevice* DeviceContext::get_eigen_device<Eigen::DefaultDevice>() | |||
| return reinterpret_cast<const CPUDeviceContext*>(this)->eigen_device(); | |||
| } | |||
|
|
|||
| CPUDeviceContext::CPUDeviceContext() { | |||
There was a problem hiding this comment.
Move implementation into *.cc to make the definition clearer.
gangliao
commented
Jul 27, 2017
| } | ||
|
|
||
| CUDADeviceContext::~CUDADeviceContext() { | ||
| SetDeviceId(place_.device); |
There was a problem hiding this comment.
add SetDeviceId(place_.device); in here
gangliao
commented
Jul 27, 2017
| PADDLE_ENFORCE(cudaStreamDestroy(stream_)); | ||
| } | ||
|
|
||
| Place CUDADeviceContext::GetPlace() const { return place_; } |
There was a problem hiding this comment.
Fix bug in here, return place_
gangliao
commented
Jul 27, 2017
| eigen_device_.reset(new Eigen::DefaultDevice()); | ||
| } | ||
|
|
||
| CPUDeviceContext::CPUDeviceContext(CPUPlace place) { |
There was a problem hiding this comment.
Keep unified cpu and gpu interface
gangliao
commented
Jul 27, 2017
|
|
||
| cublasHandle_t blas_handle_{nullptr}; | ||
| private: | ||
| uint64_t seed_; |
There was a problem hiding this comment.
It's better to set seed to uint64_t and I will also add rand method for CPU in next PR
gangliao
changed the title
QiJune
reviewed
Jul 28, 2017
| @@ -56,7 +56,7 @@ void Copy<platform::GPUPlace, platform::GPUPlace>(platform::GPUPlace dst_place, | |||
| const void* src, size_t num, | |||
| cudaStream_t stream) { | |||
| if (dst_place == src_place) { | |||
| platform::GPUPlaceGuard g(src_place.device); | |||
| platform::SetDeviceId(src_place.device); | |||
There was a problem hiding this comment.
这个不需要了 因为GpuMemcpyPeer函数里面的两个参数 就是相应的device id
heavengate
added a commit
to heavengate/Paddle
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.