Skip to content

align the default value of some configuration for fleet to that of single cards #30740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 24, 2021
Merged

align the default value of some configuration for fleet to that of single cards #30740

merged 6 commits into from
Feb 24, 2021

Conversation

@sandyhouse
Copy link

@sandyhouse sandyhouse commented Jan 28, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

align the default value of some configuration for fleet to that of single cards (i.e., the values of main framework instead of the values in fleet).

  1. cudnn_exhaustive_search
  2. cudnn_batchnorm_spatial_persistent
  3. conv_workspace_size_limit
  4. sync_nccl_allreduce

Todo:
how to deal with fuse_parameter_memory_size, the default value of which is -1 in framework, which is incompatible with dygraph (reducer).

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

Sorry to inform you that d60b7b9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Feb 22, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Feb 22, 2021
wangxicoding
wangxicoding approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@wangxicoding wangxicoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyhouse sandyhouse requested a review from chalsliu February 24, 2021 09:57
@sandyhouse sandyhouse merged commit dc8dfba into PaddlePaddle:develop Feb 24, 2021
sandyhouse pushed a commit to sandyhouse/Paddle that referenced this pull request Feb 25, 2021
align the default value of some configuration for fleet to that of si…
1240e4f 
…ngle cards (PaddlePaddle#30740)

* update, test=develop
fuyinno4 pushed a commit that referenced this pull request Mar 2, 2021
[CP] align fleet param (#31220)
d15e73b 
* update, test=develop (#30692)

* align the default value of some configuration for fleet to that of single cards (#30740)

* update, test=develop
@sandyhouse sandyhouse deleted the fix_default_strategy_value branch March 8, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxicoding wangxicoding wangxicoding approved these changes

@chalsliu chalsliu chalsliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandyhouse @wangxicoding @chalsliu