-
Notifications
You must be signed in to change notification settings - Fork 5.9k
add 9 Inplace APIs that have core.ops implementation in its original APIs #30607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! |
| def test_broadcast_errors(self): | ||
| paddle.disable_static() | ||
| x = paddle.rand([3, 4]) | ||
| y = paddle.rand([2, 3, 4]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add more comlecated broadcast testcases, e.g., [1,2,1,3] and [4,2,5,1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
python/paddle/tensor/math.py
Outdated
| inplace_shape = x.shape | ||
| out = _elementwise_op_in_dygraph( | ||
| x, y, axis=axis, op_name=op_type) | ||
| if inplace_shape != out.shape: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check should be down before the execution of the op.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
Sorry to inform you that a2cec25's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
Since you haven't replied for more than a year, we have closed this issue/pr. |
PR types
New features
PR changes
APIs
Describe
Inplace Strategy has been implemented in PR #30103 .
Add 9 Inplace APIs in this PR.