Skip to content

Conversation

@hbwx24
Copy link
Contributor

@hbwx24 hbwx24 commented Jan 18, 2021

PR types

Bug fixes

PR changes

APIs

Describe

cherry-pick两个PR

PR1:

一、
test_paddle_save_load, test_static_save_load单测随机挂,如下图:
image
原因:mac os python3.5/6 pickle.dump 当存储对象大于4GB时有bug。

二、使用numpy.array_equal替代两个array做差的比较形式。

原始PR:#30485

PR2:

补充修复paddle.save/static.save无法存储超4G大参数的PR( #29988 ),为load_program_stateset_program_state添加解析超大参数的代码,使其兼容修改。

原始PR#30507

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jan 18, 2021

✅ This PR's description meets the template requirements!
Please wait for other CI results.

* Avoid  bug on 'MAC python3.5/6'.

* Choose the saving method according to the OS.

* smaller length of '_unpack_saved_dict' for MAC OS.

* add version information of Python.

* Edit comment.
@hbwx24 hbwx24 force-pushed the cp2.0/save_load_supplement29988 branch from 653841b to 1436ea4 Compare January 18, 2021 14:08
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save/load bug修复,预期对openblas计算无影响。
windows-openblas流水线可以豁免

@hbwx24 hbwx24 changed the title Supplement PR29988(https://github.com/PaddlePaddle/Paddle/pull/29988)… 修复save/load相关的两个bug Jan 19, 2021
@lanxianghit lanxianghit changed the title 修复save/load相关的两个bug [cherry pick]修复save/load相关的两个bug Jan 19, 2021
@lanxianghit lanxianghit merged commit 832032c into PaddlePaddle:release/2.0 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants