Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: GetAttrValue should deal with attr with attrType vector<double> #30536

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Fix bug: GetAttrValue should deal with attr with attrType vector<double> #30536

merged 1 commit into from
Jan 19, 2021

Conversation

liym27
Copy link
Contributor

@liym27 liym27 commented Jan 18, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

As the title

Before this PR, run code as follows:

model = LayerWithSetValue(input_dim=10, hidden=1)
x = paddle.full(shape=[5, 10], fill_value=5.0, dtype="float32")
paddle.jit.save(
    layer=model,
    path="./layer_use_set_value",
    input_spec=[x],
    output_spec=None)

RuntimeError:

RuntimeError: (Unavailable) Unsupport attribute type 12. (at/home/teamcity/work/ef54dc8a5b211854/paddle/fluid/framework/attribute.cc:74)

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jan 18, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

paddle-bot-old bot referenced this pull request Jan 18, 2021
@liym27
Fix bug: GetAttrValue should deal with attr with attrType vector<double>
3eebbb6
@liym27 liym27 force-pushed the fix_bug_GetAttrValue_vector_float64 branch from 3eebbb6 to 5799921 Compare January 19, 2021 03:42
@liym27 liym27 requested a review from zhhsplendid January 19, 2021 06:11
zhhsplendid
zhhsplendid approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27 liym27 mentioned this pull request Jan 19, 2021
Merged
@liym27 liym27 merged commit ff25c5b into PaddlePaddle:develop Jan 19, 2021
lanxianghit pushed a commit that referenced this pull request Jan 19, 2021
@liym27
[Cherry-Pick] Fix bug: GetAttrValue should deal with attr with attrTy…
f15bed1 
…pe vector<double> (#30564)

cherry-pick #30536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liym27 @zhhsplendid