Skip to content

fix error message of Inplace strategy #30520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

fix error message of Inplace strategy #30520

merged 1 commit into from
Jan 19, 2021
+17 −12

Conversation

@pangyoki
Copy link
Contributor

@pangyoki pangyoki commented Jan 18, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

Inplace strategy in dygraph refers to PR #30103 .
This PR refine the error message while developing Inplace strategy.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@pangyoki pangyoki requested review from chenwhql and zhiqiu January 18, 2021 05:12
chenwhql
chenwhql approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改报错信息，不涉及计算操作风险。
windows-openblas流水线可以豁免

@pangyoki pangyoki merged commit 00554b3 into PaddlePaddle:develop Jan 19, 2021
pangyoki added a commit to pangyoki/Paddle that referenced this pull request Jan 19, 2021
@pangyoki
Cherry-pick PR 30520. fix error message of Inplace strategy (PaddlePa…
18d30a0 
…ddle#30520)
@pangyoki pangyoki mentioned this pull request Jan 19, 2021
Merged
lanxianghit pushed a commit that referenced this pull request Jan 19, 2021
@pangyoki
[Cherry-pick] PR 30520. fix error message of Inplace strategy (#30520) (
40b3e75 
#30568)

Cherry pick PR #30520 .
Fix error message of Inplace strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@chenwhql chenwhql chenwhql approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pangyoki @zhiqiu @chenwhql @lanxianghit