Skip to content

[2.0 API] device guard #30307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2021
Merged

[2.0 API] device guard #30307

merged 3 commits into from
Jan 19, 2021

Conversation

@zhangting2020
Copy link
Contributor

@zhangting2020 zhangting2020 commented Jan 11, 2021 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

add 2.0 API device_guard

主要修改点：

  • device_guard迁移至static目录
  • 文档中去除了所有fluid的使用

image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle-bot-old bot referenced this pull request Jan 11, 2021
@zhangting2020
fix unittest
f9f4ffe
TCChenlong
TCChenlong previously approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jzhang533
jzhang533 previously approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhangting2020 zhangting2020 dismissed stale reviews from jzhang533 and TCChenlong via 7dfc0ef January 18, 2021 10:12
TCChenlong
TCChenlong approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangting2020 zhangting2020 merged commit 66c514c into PaddlePaddle:develop Jan 19, 2021
zhangting2020 added a commit to zhangting2020/Paddle that referenced this pull request Jan 19, 2021
@zhangting2020
[2.0 API] device guard (PaddlePaddle#30307)
7cbc7b1 
* add 2.0 API: device_guard
@zhangting2020 zhangting2020 mentioned this pull request Jan 19, 2021
Merged
XiaoguangHu01 pushed a commit that referenced this pull request Jan 19, 2021
@zhangting2020
[2.0 API] device guard (#30307) (#30562)
4632291 
* add 2.0 API: device_guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TCChenlong TCChenlong TCChenlong approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@jzhang533 jzhang533 jzhang533 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangting2020 @jzhang533 @TCChenlong @XiaoguangHu01