fix adamw apply gradient #30130
Merged
fix adamw apply gradient #30130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangxicoding
force-pushed
the
fix_adamw_apply_gradient
branch
from
e0f6567 to
7b8a46f
Compare
guoshengCS
reviewed
Jan 6, 2021
python/paddle/optimizer/adamw.py
Outdated
| assert param.dtype == paddle.fluid.core.VarDesc.VarType.FP32, \ | ||
| "the type of coeff(float) and parameter(%s) is not consistent."%(param.dtype) | ||
| else: | ||
| assert self._coeff.dtype == param.dtype, \ |
There was a problem hiding this comment.
感觉用户使用double有点麻烦，能否float时就不要求param.dtype呢，下面的decay_coeff = 1.0 - self._coeff * learning_rate一定会受影响而不是用learning_rate的dtype是吗
There was a problem hiding this comment.
Done.
1.0 - self._coeff * learning_rate，返回的tensor类型是self._coeff的类型，如果self._coeff 和 learning_rate类型不一致，会自动加cast转换类型。
把判断逻辑去掉则支持任何类型，改成1.0 - learning_rate * self._coeff使用learning_rate的类型。
guoshengCS
approved these changes
Jan 7, 2021
wangxicoding
added a commit
to wangxicoding/Paddle
that referenced
this pull request
Jan 7, 2021
fuyinno4
pushed a commit
that referenced
this pull request
Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
paddle.optimizer.AdamW不兼容 #29794param = param - param * lr * coeffis optimized as followsparam = param * (1.0 - lr * coeff)