Skip to content

Conversation

@MingMingShangTian
Copy link
Contributor

PR types

Others

PR changes

OPs

Describe

add trace op_register_version and fix default version bug

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MingMingShangTian MingMingShangTian changed the title add trace op_register_version and fix default bug; test=op_version add trace op_register_version and fix version bug; test=op_version Dec 29, 2020
Can be either positive or negative. Default: 1.
)DOC")
.SetDefault(-1);
.SetDefault(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动貌似不能向后兼容

Shixiaowei02
Shixiaowei02 previously approved these changes Dec 31, 2020
@lfchener
Copy link
Contributor

lfchener commented Jan 4, 2021

该修改使默认行为和 numpy.trace 保持一致。
因为 API 端在调用 op 时会给 axis1 和 axis2 传入默认值,所以在 op 端的默认值实际上并没有被用到,该修改不会对 API 的行为造成影响。

@Shixiaowei02 Shixiaowei02 requested a review from Superjomn January 5, 2021 07:23
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit a5e422c into PaddlePaddle:develop Jan 5, 2021
@MingMingShangTian MingMingShangTian deleted the register_trace_version branch January 5, 2021 09:03
Shixiaowei02 pushed a commit to Shixiaowei02/Paddle that referenced this pull request Jan 11, 2021
…addlePaddle#30000)

* add trace op_register_version and fix defaulf bug; test=op_version

* add trace op_register_version; test=op_version

* add trace op_register_version; test=op_version

* add trace op_register_version; test=op_version

* fix missing the template bug of vector; test=op_version
Superjomn pushed a commit that referenced this pull request Jan 13, 2021
…ase/2.0 (#30292)

* Register op version for grid_sampler, test=op_version (#29916)

* add op version for fake_quant and fake_dequant ops, test=op_version (#29923)

* Register op version for print, test=op_version (#29945)

* add gru op_register_version; test=op_version; (#29931)

* Register op version for coalesce_tensor. (#29940)

* register op version for conv2d_transpose, conv3d_transpose and depthwise_conv2d_transpose, test=op_version (#29937)

* add op_register_version for allclose op; test=op_version (#29968)

* register ModifyAttr for instance_norm, test=op_version (#29938)

* add op_version for flip op [test=op_version] (#30019)

* add the op version check for the elementwise ops, test=op_version (#30010)

* add the support the op version check for matmul, test=op_version (#30011)

* Revert "register ModifyAttr for instance_norm, test=op_version (#29938)"

* add REGISTER_OP_VERSION for generate_proposals, roi_align, roi_pool test=op_version (#30034)

* Fix rank_attention op_version, test=op_version (#30006)

* fix rank_attention, test=op_version

* Register op version for linspace,test=op_version (#30025)

* fix op_register_version for compare ops, test=op_version (#30007)

Co-authored-by: zhoushunjie <zhoushunjie@baidu.com>

* register ModifyAttr for instance_norm, test=op_version (#30065)

* register instance norm, test=op_version

* add trace op_register_version and fix version bug; test=op_version (#30000)

* fix a bug in op_version_registry, test=develop, test=op_version (#29994)

* Add version checking, test=op_version (#30129)

* fix a bug in gaussian_random_op version, test=release/2.0

Co-authored-by: LielinJiang <50691816+LielinJiang@users.noreply.github.com>
Co-authored-by: cc <52520497+juncaipeng@users.noreply.github.com>
Co-authored-by: Qi Li <qili93@qq.com>
Co-authored-by: Jack Zhou <zhoushunjie@baidu.com>
Co-authored-by: Guo Sheng <whucsgs@163.com>
Co-authored-by: wangxinxin08 <69842442+wangxinxin08@users.noreply.github.com>
Co-authored-by: wawltor <fangzeyang0904@hotmail.com>
Co-authored-by: FlyingQianMM <245467267@qq.com>
Co-authored-by: ceci3 <ceci3@users.noreply.github.com>
Co-authored-by: hutuxian <hutuxian2011@sina.cn>
Co-authored-by: chalsliu <45041955+chalsliu@users.noreply.github.com>
Co-authored-by: wangguanzhong <jerrywgz@126.com>
Co-authored-by: ShenLiang <shenliang03@baidu.com>
Co-authored-by: yinhaofeng <66763551+yinhaofeng@users.noreply.github.com>
Co-authored-by: channings <chenlingchi@baidu.com>
Co-authored-by: chentianyu03 <chentianyu03@baidu.com>
Co-authored-by: ruri <shipeng1108@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants