Skip to content

Conversation

@ceci3
Copy link
Contributor

@ceci3 ceci3 commented Dec 28, 2020

PR types

Function optimization

PR changes

APIs

Describe

add use_global_stats attribute for batch_norm.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块的英文文档要不也添加下?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,thanks

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warnings.warn(

这里是不是也要更新。

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ceci3
Copy link
Contributor Author

ceci3 commented Jan 4, 2021

warnings.warn(

这里是不是也要更新。

这里是因为我们现在在training模式还是会计算所有global stats,这个参数是控制用不用global stats~

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ceci3 ceci3 merged commit 3342477 into PaddlePaddle:develop Jan 6, 2021
@ceci3 ceci3 deleted the fix_batch_norm branch January 6, 2021 02:56
ceci3 added a commit to ceci3/Paddle that referenced this pull request Jan 6, 2021
@ceci3 ceci3 mentioned this pull request Jan 6, 2021
hbwx24 pushed a commit to hbwx24/Paddle that referenced this pull request Jan 6, 2021
XiaoguangHu01 pushed a commit that referenced this pull request Jan 7, 2021
* fix bn docs (#30096)

* add attribute for batch_norm (#29950)

* add attribute for batch_norm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants