enable layer group to output a sequence inside it during generation #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcy-seso
force-pushed
the
print_attention_weight
branch
from
ab4d125 to
4c134c7
Compare
Merged
luotao1
reviewed
Aug 3, 2017
Contributor
luotao1
left a comment
luotao1
left a comment
There was a problem hiding this comment.
可以把第一个commit单独拿出来先merge了。后面几个commit可以再拆的细一点，方便review。
| * sequence in Matrix stored the entire beam search batch's forward pass | ||
| * results. | ||
| * | ||
| * @param isSeq: a flag indicating whetehr the layer to be output of the |
| * | ||
| * @param isSeq: a flag indicating whetehr the layer to be output of the | ||
| * RecurrentGradientMachine is a sequence or not | ||
| * @param outArgs: all of the the returned Arguments of the forward pass |
guoshengCS
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1797
fixes #1269
This PR mainly contains three modifications to RecurrentLayerGroup: