Skip to content

Conversation

helinwang
Copy link
Contributor

@helinwang helinwang commented Jul 12, 2017

The hardcoded link path is no longer needed. (fixed by #2811)

@helinwang helinwang changed the title go_binary: remove hardcoded library link path go_binary: remove hardcoded library link path, add pserver client test Jul 12, 2017
@helinwang helinwang requested review from dzhwinter and gangliao July 13, 2017 00:21
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gangliao gangliao merged commit e6e2bf4 into PaddlePaddle:develop Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants