Remove buggy BarrierStat #2740
Merged
Remove buggy BarrierStat #2740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of BarrierStat is buggy, and it is not necessary for Paddle to diagnose which node in cluster is slow.
typhoonzero
reviewed
Jul 5, 2017
| "pushRecv", timeToMicroSecond(*handleRequestBegin_), -1, *statSet_); | ||
| } | ||
|
|
||
| #ifndef PADDLE_DISABLE_TIMER |
There was a problem hiding this comment.
Should also remove the cmake flag WITH_TIMER
There was a problem hiding this comment.
WITH_TIMER is not totally removed. It is used to calculate execution time for each layer and whole neural network in trainer side.
This PR only removes the BarrierStats, that used in PServer
| isSparseServer_ ? "_sparseUpdater" : "_denseUpdater"); | ||
| } | ||
|
|
||
| { |
There was a problem hiding this comment.
Should not remove this {
There was a problem hiding this comment.
This is a diff display error. That { is in line 384/368
typhoonzero
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of BarrierStat is buggy, and it is not necessary
for Paddle to diagnose which node in cluster is slow.