Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hapi.model._save_inference_model by using new features of dy2stat in 2.0-beta API #27272

Conversation

LiuChiachi
Copy link
Contributor

@LiuChiachi LiuChiachi commented Sep 11, 2020

PR types

New features

PR changes

APIs

Describe

This PR solved 3 TODOs in last PR #25894 about hapi.model._save_inference_model by using new features of dy2stat #25960 in 2.0-beta API.

  1. Make it Unnecessary to run model before calling _save_inference_model for users in dygraph.
  2. Save correct shape of input, now the interface stores the shape that the user sent to
    the inputs of the model in running.
  3. Make it Unnecessary to add @paddle.jit.to_static for users in dynamic mode.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

guoshengCS
guoshengCS previously approved these changes Sep 16, 2020
Copy link

@saxon-zh saxon-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants