-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[draft] a simple op design doc #2695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] a simple op design doc #2695
Conversation
|
||
message VarProto { | ||
required string name = 1; | ||
required string comment = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider add bool is_tensor = 3;
.
required string comment = 5; | ||
}; | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
Python APIs are divided into two types, high-level API and low-level API. | ||
|
||
### High-Level API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddle.layer?
doc/design/simple_op_design.md
Outdated
|
||
*TODO* | ||
|
||
## Op and Kernal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section "Op and kernel" need more discussion. We can remove this section from this PR, and merge it. So we could add this section in future PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
doc/design/simple_op_design.md
Outdated
message AttrProto { | ||
required string name = 1; | ||
required string comment = 2; | ||
optional AttrValue default = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given
virtual bool Operator::ValidateAttrs() const {}
we don't need max and min here.
Work in parallel:
|
No description provided.